Skip to content

fix: check existing venv before creating a new one (#64)#72

Open
YoussefMoRabie wants to merge 1 commit intomainfrom
fix/check-existing-venv-before-creating
Open

fix: check existing venv before creating a new one (#64)#72
YoussefMoRabie wants to merge 1 commit intomainfrom
fix/check-existing-venv-before-creating

Conversation

@YoussefMoRabie
Copy link

@YoussefMoRabie YoussefMoRabie commented Feb 7, 2025 •
edited
Loading

Description

Checklist

  • My code follows the [contributing guidelines][contributing-guidelines] of this
    project, including, in particular, with regard to any style guidelines
  • The title of my PR complies with the [Conventional Commits
    specification][conv-commits]; in particular, it clearly indicates
    that a change is a breaking change
  • I acknowledge that all my commits will be squashed into a single commit,
    using the PR title as the commit message
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have updated the user-facing documentation to describe any new or
    changed behavior
  • I have added type annotations for all function/class/method interfaces
    or updated existing ones (only for Python, TypeScript, etc.)
  • I have provided appropriate documentation ([Google-style Python
    docstrings][py-doc-google]) for all packages/modules/functions/classes/
    methods or updated existing ones
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature
    works
  • New and existing unit tests pass locally with my changes
  • I have not reduced the existing code coverage

Summary by Sourcery

Bug Fixes:

  • Fixes an issue where a new virtual environment was created even if one already existed.

@sourcery-ai
Copy link

sourcery-ai bot commented Feb 7, 2025 •
edited
Loading

🧙 Sourcery has finished reviewing your pull request!

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Feb 7, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @YoussefMoRabie - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

JaeAeich
JaeAeich approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@JaeAeich JaeAeich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JaeAeich
JaeAeich approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@JaeAeich JaeAeich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uniqueg
Copy link
Member

uniqueg commented Mar 5, 2025

@JaeAeich or @YoussefMoRabie: Please merge, given that it's approved ✌️

@uniqueg
Copy link
Member

uniqueg commented Mar 5, 2025

However, maybe check my comment in #64 first to see if the improvement in time outweighs the loss in confidence that .venv actually contains what it should contain...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@JaeAeich JaeAeich JaeAeich approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix: check existing venv before creating venv

3 participants

@YoussefMoRabie @uniqueg @JaeAeich